rdhabalia commented on code in PR #60:
URL: https://github.com/apache/pulsar-adapters/pull/60#discussion_r1978026410
##########
pulsar-storm/src/main/java/org/apache/pulsar/storm/PulsarSpout.java:
##########
@@ -159,6 +159,21 @@ public void ack(Object msgId) {
}
}
+ public void negativeAck(Object msgId) {
Review Comment:
yes, let's rename it to `msg` as it's not msgId
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
