BewareMyPower commented on code in PR #1340:
URL: https://github.com/apache/pulsar-client-go/pull/1340#discussion_r1972873268
##########
pulsar/consumer_test.go:
##########
@@ -1262,8 +1262,9 @@ func TestConsumerSeek(t *testing.T) {
defer producer.Close()
consumer, err := client.Subscribe(ConsumerOptions{
- Topic: topicName,
- SubscriptionName: "sub-1",
+ Topic: topicName,
+ SubscriptionName: "sub-1",
+ StartMessageIDInclusive: true,
Review Comment:
This change seems irrelevant?
##########
pulsar/consumer_zero_queue_test.go:
##########
@@ -474,6 +474,7 @@ func TestZeroQueueConsumer_Seek(t *testing.T) {
Topic: topicName,
EnableZeroQueueConsumer: true,
SubscriptionName: "sub-1",
+ StartMessageIDInclusive: true,
Review Comment:
irrelevant change again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
