BewareMyPower commented on code in PR #1340:
URL: https://github.com/apache/pulsar-client-go/pull/1340#discussion_r1978554860
##########
pulsar/consumer_test.go:
##########
@@ -1262,8 +1262,9 @@ func TestConsumerSeek(t *testing.T) {
defer producer.Close()
consumer, err := client.Subscribe(ConsumerOptions{
- Topic: topicName,
- SubscriptionName: "sub-1",
+ Topic: topicName,
+ SubscriptionName: "sub-1",
+ StartMessageIDInclusive: true,
Review Comment:
Anyway, this is a breaking change. Though the existing behavior might not be
expected, users might already depend on this behavior.
Unlike `hasNext()`, the existing behavior is that if a consumer seeks to the
message id, it will still consume that message. While this PR's main purpose is
to resolve the wrong result of `hasNext()`. I think you should use a different
PR for changing the `seek` behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
