shibd commented on code in PR #1340:
URL: https://github.com/apache/pulsar-client-go/pull/1340#discussion_r1983243828
##########
pulsar/consumer_test.go:
##########
@@ -1262,8 +1262,9 @@ func TestConsumerSeek(t *testing.T) {
defer producer.Close()
consumer, err := client.Subscribe(ConsumerOptions{
- Topic: topicName,
- SubscriptionName: "sub-1",
+ Topic: topicName,
+ SubscriptionName: "sub-1",
+ StartMessageIDInclusive: true,
Review Comment:
I do not agree that this is a break change; it is more like a behavior fix
or bug fix.
After this PR, it will keep the same behavior with the java client. Refer
to(peek to id-5 and receive msg from id-6):
https://github.com/apache/pulsar/blob/a1f3322ed358ab6841f0d3e43f2afcc54788b887/pulsar-broker/src/test/java/org/apache/pulsar/broker/service/SubscriptionSeekTest.java#L142-L165
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
