lhotari commented on code in PR #24096:
URL: https://github.com/apache/pulsar/pull/24096#discussion_r2009862855
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java:
##########
@@ -362,10 +362,6 @@ public synchronized void readMoreEntries() {
Position markDeletePosition = cursor.getMarkDeletedPosition();
if (lastMarkDeletePositionBeforeReadMoreEntries != markDeletePosition)
{
redeliveryMessages.removeAllUpTo(markDeletePosition.getLedgerId(),
markDeletePosition.getEntryId());
- for (Consumer consumer : consumerList) {
- consumer.getPendingAcks()
- .removeAllUpTo(markDeletePosition.getLedgerId(),
markDeletePosition.getEntryId());
- }
Review Comment:
> After you run
ConsumerAckAndDisableBrokerBatchAckTest.testAcknowledgeConcurrently more than
200 times, you will get an issue, which was leads by these lines
@poorbarcode What issue exactly happened?
How are pending acks removed (in the case of message expiration) if this
code is being removed? That's something that you should address in this PR if
you prefer to remove this code in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
