poorbarcode commented on code in PR #24096:
URL: https://github.com/apache/pulsar/pull/24096#discussion_r2009870220
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java:
##########
@@ -362,10 +362,6 @@ public synchronized void readMoreEntries() {
Position markDeletePosition = cursor.getMarkDeletedPosition();
if (lastMarkDeletePositionBeforeReadMoreEntries != markDeletePosition)
{
redeliveryMessages.removeAllUpTo(markDeletePosition.getLedgerId(),
markDeletePosition.getEntryId());
- for (Consumer consumer : consumerList) {
- consumer.getPendingAcks()
- .removeAllUpTo(markDeletePosition.getLedgerId(),
markDeletePosition.getEntryId());
- }
Review Comment:
> How are pending acks removed if this code is being removed?
I described here:
https://github.com/apache/pulsar/pull/24096#discussion_r2006825594
> That's something that you should address in this PR if you prefer to
remove this code in this PR.
I feel that pip-379 should solve this problem because these lines of code
were added by PIP-379 in order avoid to solving the problems you described at
https://github.com/apache/pulsar/pull/24096#discussion_r2003692893
Another solution is to left these lines there, then the test
`ConsumerAckAndDisableBrokerBatchAckTest.testAcknowledgeConcurrently` will be a
flaky test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
