poorbarcode commented on code in PR #24178:
URL: https://github.com/apache/pulsar/pull/24178#discussion_r2057296772
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImplementationBindingImpl.java:
##########
@@ -327,7 +327,7 @@ public KeyValue<SchemaInfo, SchemaInfo>
decodeKeyValueSchemaInfo(SchemaInfo sche
* @return the jsonified schema info
*/
public String jsonifySchemaInfo(SchemaInfo schemaInfo) {
- return SchemaUtils.jsonifySchemaInfo(schemaInfo);
+ return SchemaUtils.jsonifySchemaInfo(schemaInfo, false);
Review Comment:
Removed this change, I will start a discussion for it
##########
pulsar-common/src/main/java/org/apache/pulsar/client/impl/schema/SchemaInfoImpl.java:
##########
@@ -117,6 +117,6 @@ public SchemaHash getSchemaHash() {
@Override
public String toString() {
- return SchemaUtils.jsonifySchemaInfo(this);
+ return SchemaUtils.jsonifySchemaInfo(this, false);
Review Comment:
Removed this change, I will start a discussion for it
##########
pulsar-common/src/main/java/org/apache/pulsar/client/impl/schema/SchemaUtils.java:
##########
@@ -200,12 +200,13 @@ public static String getStringSchemaVersion(byte[]
schemaVersionBytes) {
* @param schemaInfo the schema info
* @return the jsonified schema info
*/
- public static String jsonifySchemaInfo(SchemaInfo schemaInfo) {
Review Comment:
Removed this change. I will start a discussion for it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
