poorbarcode commented on code in PR #24178:
URL: https://github.com/apache/pulsar/pull/24178#discussion_r2057593239
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java:
##########
@@ -198,6 +201,10 @@ public ProducerImpl(PulsarClientImpl client, String topic,
ProducerConfiguration
this.userProvidedProducerName = StringUtils.isNotBlank(producerName);
this.partitionIndex = partitionIndex;
this.pendingMessages = createPendingMessagesQueue();
+ // Replication needs to be paused when a message can not be replicated
due to failed schema registration.
+ // Otherwise, it may cause an out-of-order issue, and it may lead to a
messages lost issue if users enabled
+ // deduplication on the remote side.
+ this.pauseSendingToPreservePublishOrderOnSchemaRegFailure =
conf.isReplProducer();
Review Comment:
Main change 3:
Replication should not skip the messages who contain a broken schema
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
