lhotari commented on code in PR #24457: URL: https://github.com/apache/pulsar/pull/24457#discussion_r2166681043
########## pulsar-common/src/main/java/org/apache/pulsar/common/naming/TopicNameCache.java: ########## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pulsar.common.naming; + +import java.util.concurrent.TimeUnit; + +/** + * A cache for TopicName instances that allows deduplication and efficient memory usage. + * It uses soft references to allow garbage collection of unused TopicName instances under heavy memory pressure. + * This cache uses ConcurrentHashMap for lookups for performance over Guava Cache and Caffeine Cache + * since there was a concern in https://github.com/apache/pulsar/pull/23052 about high CPU usage for cache lookups. + */ +class TopicNameCache extends NameCache<TopicName> { + static final TopicNameCache INSTANCE = new TopicNameCache(); + // Configuration for the cache. These settings aren't currently exposed to end users. + static int cacheMaxSize = 100000; Review Comment: The configuration setting could be restored. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
