AuroraTwinkle commented on code in PR #24574:
URL: https://github.com/apache/pulsar/pull/24574#discussion_r2236336050
##########
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/ServiceUrlQuarantineTest.java:
##########
@@ -82,16 +83,16 @@ protected void setup() throws Exception {
.serviceUrl(binaryServiceUrlWithUnavailableNodes)
.serviceUrlQuarantineInitDuration(0,
TimeUnit.MILLISECONDS)
.serviceUrlQuarantineMaxDuration(0,
TimeUnit.MILLISECONDS)
- .operationTimeout(TIMEOUT_SECONDS,
TimeUnit.SECONDS)
- .lookupTimeout(TIMEOUT_SECONDS,
TimeUnit.SECONDS)
+ .operationTimeout(TIMEOUT_MS, TimeUnit.SECONDS)
+ .lookupTimeout(TIMEOUT_MS, TimeUnit.SECONDS)
.build();
this.pulsarClientWithHttpServiceUrlDisableQuarantine =
(PulsarClientImpl) PulsarClient.builder()
.serviceUrl(httpServiceUrlWithUnavailableNodes)
.serviceUrlQuarantineInitDuration(0,
TimeUnit.MILLISECONDS)
.serviceUrlQuarantineMaxDuration(0,
TimeUnit.MILLISECONDS)
- .operationTimeout(TIMEOUT_SECONDS, TimeUnit.SECONDS)
- .lookupTimeout(TIMEOUT_SECONDS, TimeUnit.SECONDS)
+ .operationTimeout(TIMEOUT_MS, TimeUnit.SECONDS)
+ .lookupTimeout(TIMEOUT_MS, TimeUnit.SECONDS)
Review Comment:
> should use `TimeUnit.MILLISECONDS`?
Sorry, there are some other failures in ci, I will fix them together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
