AuroraTwinkle commented on code in PR #24574:
URL: https://github.com/apache/pulsar/pull/24574#discussion_r2238300838
##########
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/ServiceUrlQuarantineTest.java:
##########
@@ -82,16 +83,16 @@ protected void setup() throws Exception {
.serviceUrl(binaryServiceUrlWithUnavailableNodes)
.serviceUrlQuarantineInitDuration(0,
TimeUnit.MILLISECONDS)
.serviceUrlQuarantineMaxDuration(0,
TimeUnit.MILLISECONDS)
- .operationTimeout(TIMEOUT_SECONDS,
TimeUnit.SECONDS)
- .lookupTimeout(TIMEOUT_SECONDS,
TimeUnit.SECONDS)
+ .operationTimeout(TIMEOUT_MS, TimeUnit.SECONDS)
+ .lookupTimeout(TIMEOUT_MS, TimeUnit.SECONDS)
.build();
this.pulsarClientWithHttpServiceUrlDisableQuarantine =
(PulsarClientImpl) PulsarClient.builder()
.serviceUrl(httpServiceUrlWithUnavailableNodes)
.serviceUrlQuarantineInitDuration(0,
TimeUnit.MILLISECONDS)
.serviceUrlQuarantineMaxDuration(0,
TimeUnit.MILLISECONDS)
- .operationTimeout(TIMEOUT_SECONDS, TimeUnit.SECONDS)
- .lookupTimeout(TIMEOUT_SECONDS, TimeUnit.SECONDS)
+ .operationTimeout(TIMEOUT_MS, TimeUnit.SECONDS)
+ .lookupTimeout(TIMEOUT_MS, TimeUnit.SECONDS)
Review Comment:
> Yes, Pulsar CI is broken currently and would be fixed by #24569.
>
> In the meantime, it's sufficient to make the changes that I pointed out in
my review (please address [#24574
(comment)](https://github.com/apache/pulsar/pull/24574#issuecomment-3126811529)).
Just validate the test locally and push the changes to this PR so that we can
proceed in addressing this PR while Pulsar CI is blocked.
OK, I have passed the local test and pushed to this PR. When my forked
repository CI passes, I will notify you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
