lhotari commented on code in PR #24574:
URL: https://github.com/apache/pulsar/pull/24574#discussion_r2239226048
##########
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/ServiceUrlQuarantineTest.java:
##########
@@ -67,8 +68,12 @@ protected void setup() throws Exception {
StringBuilder binaryServiceUrlBuilder = new
StringBuilder(pulsar.getBrokerServiceUrl());
StringBuilder httpServiceUrlBuilder = new
StringBuilder(pulsar.getWebServiceAddress());
for (int i = 0; i < UNAVAILABLE_NODES; i++) {
-
binaryServiceUrlBuilder.append(",127.0.0.1:").append(ThreadLocalRandom.current().nextInt(100,
1000));
-
httpServiceUrlBuilder.append(",127.0.0.1:").append(ThreadLocalRandom.current().nextInt(100,
1000));
+ int newLockedFreePort = PortManager.nextLockedFreePort();
+ lockedFreePortSet.add(newLockedFreePort);
Review Comment:
You could extract a method for this
##########
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/ServiceUrlQuarantineTest.java:
##########
@@ -53,10 +53,11 @@ public class ServiceUrlQuarantineTest extends
ProducerConsumerBase {
private PulsarClientImpl pulsarClientWithBinaryServiceUrlDisableQuarantine;
private PulsarClientImpl pulsarClientWithHttpServiceUrl;
private PulsarClientImpl pulsarClientWithHttpServiceUrlDisableQuarantine;
- private static final int BROKER_SERVICE_PORT = 6666;
- private static final int WEB_SERVICE_PORT = 8888;
+ private final int brokerServicePort = PortManager.nextLockedFreePort();
+ private final int webServicePort = PortManager.nextLockedFreePort();
Review Comment:
Set these in the setup method. We have retries for TestNG to address
flakiness so that's why it's better to handle it that way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
