sijie commented on a change in pull request #5045: [client] Introduce
`batchingMaxBytes` setting in pulsar producer
URL: https://github.com/apache/pulsar/pull/5045#discussion_r317838246
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerBuilderImpl.java
##########
@@ -212,6 +212,12 @@ private ProducerBuilderImpl(PulsarClientImpl client,
ProducerConfigurationData c
return this;
}
+ @Override
+ public ProducerBuilder<T> batchingMaxBytes(int batchingMaxBytes) {
+ conf.setBatchingMaxBytes(batchingMaxBytes);
Review comment:
I removed the check for `>0` to allow users choosing the right batching
strategy.
I will add the check for MAX_FRAME_SIZE.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
