sijie commented on a change in pull request #5045: [client] Introduce
`batchingMaxBytes` setting in pulsar producer
URL: https://github.com/apache/pulsar/pull/5045#discussion_r317874900
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/AbstractBatchMessageContainer.java
##########
@@ -37,11 +37,11 @@
protected ProducerImpl producer;
protected int maxNumMessagesInBatch;
+ protected int maxBytesInBatch;
protected int numMessagesInBatch = 0;
protected long currentBatchSizeBytes = 0;
- protected static final int INITIAL_BATCH_BUFFER_SIZE = 1024;
- protected static final int MAX_MESSAGE_BATCH_SIZE_BYTES = 128 * 1024;
+ protected static final int INITIAL_BATCH_BUFFER_SIZE = 128 * 1024;
Review comment:
Good point. I will probably just assign different values for different
containers
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
