lhotari commented on code in PR #24423: URL: https://github.com/apache/pulsar/pull/24423#discussion_r2357650285
########## pulsar-common/src/main/java/org/apache/pulsar/common/util/TimedSingleThreadRateLimiter.java: ########## Review Comment: There shouldn't be a need to put this directly in `pulsar-common`. I'd recommend keeping this in `pulsar-broker`. If it's needed in other server side components (such as `pulsar-proxy`), `pulsar-broker-common` should be preferred over `pulsar-common`. The reason for this is that `pulsar-common` is meant for classes that are shared with the Pulsar client too. In Pulsar 3.0.x, that is Java 8 only. Please move to `pulsar-broker` for now and if there's a need to reuse, it can be moved later. Are there any tests for this class? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
