lhotari commented on code in PR #24423:
URL: https://github.com/apache/pulsar/pull/24423#discussion_r2370219551
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java:
##########
@@ -438,11 +451,53 @@ public void channelInactive(ChannelHandlerContext ctx)
throws Exception {
}
}
+ private void checkRateLimit(BaseCommand cmd) {
+ if (cmd.getType() == BaseCommand.Type.PONG && cmd.getType() ==
BaseCommand.Type.PING) {
Review Comment:
fix `&&` -> `||` and also return if `!pauseReceivingRequestsIfUnwritable` or
`rateLimitingSecondsAfterResumeFromUnreadable < 0`
```suggestion
if (!pauseReceivingRequestsIfUnwritable ||
rateLimitingSecondsAfterResumeFromUnreadable < 0 || cmd.getType() ==
BaseCommand.Type.PONG || cmd.getType() == BaseCommand.Type.PING) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
