zhanghaou commented on PR #24745:
URL: https://github.com/apache/pulsar/pull/24745#issuecomment-3314247717
@lhotari
> * An ordinary executor behaves in a different way than the ForkJoinPool.
ForkJoinPool can expand the number of threads when it detects blocking and
handle this efficiently. This might be relevant in some of the current usage of
executors. Switching to use an ordinary executor could cause deadlocks in
certain cases where the existing code doesn't deadlock because of ForkJoinPool.
The purpose of this PR is to achieve thread-pool isolation, rather than to
compare whether the ForkJoin pool is better than a regular thread pool. For
example, in your previous PR https://github.com/apache/pulsar/pull/22589 , you
also replaced the ForkJoin common pool with Pulsar’s executor.
> * `MoreExecutor.directExecutor` shouldn't be used at all when
`refreshAfterWrite` is used with Caffeine, since it would defeat the purpose of
using background refreshing of the cached items. I don't see a reason why
someone would want to make an async Caffeine cache synchronous. That doesn't
make sense.
https://github.com/apache/pulsar/pull/24745#issuecomment-3298091512 Maybe
you miss the explanation here，I had added a new executor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
