lhotari commented on code in PR #24920:
URL: https://github.com/apache/pulsar/pull/24920#discussion_r2476523156


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractDispatcherSingleActiveConsumer.java:
##########
@@ -176,6 +176,11 @@ public synchronized CompletableFuture<Void> 
addConsumer(Consumer consumer) {
                         return FutureUtil.failedFuture(new 
ConsumerBusyException("Exclusive consumer is already"
                                 + " connected"));
                     } else {
+                        try {
+                            removeConsumer(actConsumer);
+                        } catch (BrokerServiceException e) {
+                            log.warn("[{}] Remove inactive exclusive consumer 
{}", this.topicName, consumer);
+                        }

Review Comment:
   Just wondering if PIP-434 is included in the forked version and that's 
causing the issue? Channel autoread=false scenario hasn't been thought out in 
the liveness check solution.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to