poorbarcode commented on code in PR #24920:
URL: https://github.com/apache/pulsar/pull/24920#discussion_r2476814697
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractDispatcherSingleActiveConsumer.java:
##########
@@ -176,6 +176,11 @@ public synchronized CompletableFuture<Void>
addConsumer(Consumer consumer) {
return FutureUtil.failedFuture(new
ConsumerBusyException("Exclusive consumer is already"
+ " connected"));
} else {
+ try {
+ removeConsumer(actConsumer);
+ } catch (BrokerServiceException e) {
+ log.warn("[{}] Remove inactive exclusive consumer
{}", this.topicName, consumer);
+ }
Review Comment:
- `checkConnectionLiveness` returned `false`.
- The active consumer was not removed.
Seems we should fix the behaviour of `checkConnectionLiveness` or `remove
consumers if the connection is inactive`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
