lhotari commented on code in PR #24833:
URL: https://github.com/apache/pulsar/pull/24833#discussion_r2500577397
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/TopicListService.java:
##########
@@ -101,6 +112,7 @@ public void accept(String topicName, NotificationType
notificationType) {
private final boolean enableSubscriptionPatternEvaluation;
private final int maxSubscriptionPatternLength;
private final ConcurrentLongHashMap<CompletableFuture<TopicListWatcher>>
watchers;
+ private final Backoff retryBackoff;
public TopicListService(PulsarService pulsar, ServerCnx connection,
Review Comment:
@poorbarcode I've addressed the required changes. Topic list watchers will
work fine with this solution. In case of running out of permits, there will be
infinite retries (until the watcher is closed by closing it's connection).
Backpressure is about slowing down responses in this case to reduce the load on
the system. I'll continue to add a test case where the problems of the existing
solution would be demonstrated in the similar way as there's
org.apache.pulsar.client.api.PatternConsumerBackPressureMultipleConsumersTest,
but using actual client consumers that use topic list watchers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
