poorbarcode commented on code in PR #24833:
URL: https://github.com/apache/pulsar/pull/24833#discussion_r2501961567
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/TopicListService.java:
##########
@@ -101,6 +112,7 @@ public void accept(String topicName, NotificationType
notificationType) {
private final boolean enableSubscriptionPatternEvaluation;
private final int maxSubscriptionPatternLength;
private final ConcurrentLongHashMap<CompletableFuture<TopicListWatcher>>
watchers;
+ private final Backoff retryBackoff;
public TopicListService(PulsarService pulsar, ServerCnx connection,
Review Comment:
> That doesn't hold since the solution will retry with back off in case of
errors.
It absolutely holds, because you set a `MAX_RETRY_COUNT (default value is
10) `, right?
> In case of running out of permits, there will be infinite retries (until
the watcher is closed by closing it's connection).
This new change can solve the issue I mentioned. But I still think that we'd
better remove this limitation because the topic change event uses less memory,
and the event will rarely occur
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
