lhotari commented on PR #25211: URL: https://github.com/apache/pulsar/pull/25211#issuecomment-3847727454
> I will try to use the ProxyContinueProtocolHandler tomorrow. One possible approach would be to change the `createHttpClient` method in `org.apache.pulsar.proxy.server.AdminProxyHandler` so that it calls super.createHttpClient() and then apply the customization `client.getProtocolHandlers().put(new RedirectProtocolHandler(client))`. I didn't spot other relevant differences. This type of change would remove the need for code duplication in `AdminProxyHandler` and would be useful for both Jetty 9.x and 12.x implementations. The ProxyContinueProtocolHandler isn't visible to AdminProxyHandler and in the Jetty 12.x upgrade PR I had to copy the class to add similar logic. That wouldn't be necessary with the `HttpClient client = super.createHttpClient(); client.getProtocolHandlers().put(new RedirectProtocolHandler(client)); return client` implementation for `createHttpClient` in `AdminProxyHandler`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
