nodece commented on PR #25211: URL: https://github.com/apache/pulsar/pull/25211#issuecomment-3850980438
Thanks for the suggestion, and I agree that this is a better and cleaner approach. After validating the behavior with packet captures, I realized that my previous change only guarantees correct handling of `Expect: 100-continue` on the **client → proxy** hop. In that setup, Jetty on the proxy side consumes the `Expect` header and sends the `100 Continue` response back to the client, but the **proxy → broker** request does not necessarily follow the same continue semantics. Your proposal to have `AdminProxyHandler#createHttpClient` call `super.createHttpClient()` and then apply the additional customization (e.g. registering `RedirectProtocolHandler`) ensures that the standard Jetty `ContinueProtocolHandler` logic is preserved consistently. This makes the `Expect: 100-continue` behavior work end-to-end, including the **proxy → broker** hop, rather than being limited to the incoming request only. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
