lhotari commented on code in PR #25229:
URL: https://github.com/apache/pulsar/pull/25229#discussion_r2780981608
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/NegativeAcksTracker.java:
##########
@@ -158,7 +158,7 @@ static long trimLowerBit(long timestamp, int bits) {
private synchronized void add(MessageId messageId, int redeliveryCount) {
if (messageId instanceof TraceableMessageId) {
Span span = ((TraceableMessageId) messageId).getTracingSpan();
- if (span != null) {
+ if (span != null || messageId instanceof ChunkMessageIdImpl) {
Review Comment:
The change made in #24873 in this part of the code is slightly confusing. It
adds back some logic before #23600/#23582 which broke the nacks for chunked
messages. I'm just wondering why this change was made in #24873. @Technoboy-
would you be able to share some more context?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
