lhotari commented on code in PR #25229:
URL: https://github.com/apache/pulsar/pull/25229#discussion_r2781111176
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/NegativeAcksTracker.java:
##########
@@ -158,7 +158,7 @@ static long trimLowerBit(long timestamp, int bits) {
private synchronized void add(MessageId messageId, int redeliveryCount) {
if (messageId instanceof TraceableMessageId) {
Span span = ((TraceableMessageId) messageId).getTracingSpan();
- if (span != null) {
+ if (span != null || messageId instanceof ChunkMessageIdImpl) {
Review Comment:
It seems that this change is fine from the PIP-393 optimization perspective.
The additional overhead would be present only when tracing (added in #24873),
and when the message id is a ChunkMessageIdImpl (added in this PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
