Jennifer88huang commented on a change in pull request #5092: [doc] Improve
Pulsar Security Extending
URL: https://github.com/apache/pulsar/pull/5092#discussion_r321196840
##########
File path: site2/docs/security-extending.md
##########
@@ -27,35 +23,30 @@ PulsarClient client = PulsarClient.builder()
.build();
```
-For reference, there are 2 interfaces to implement on the client side:
+For reference, you can use 2 interfaces to implement on the client side:
* `Authentication` ->
http://pulsar.apache.org/api/client/org/apache/pulsar/client/api/Authentication.html
* `AuthenticationDataProvider` ->
http://pulsar.apache.org/api/client/org/apache/pulsar/client/api/AuthenticationDataProvider.html
-This in turn will need to provide the client credentials in the form of
`org.apache.pulsar.client.api.AuthenticationDataProvider`. This will leave
-the chance to return different kinds of authentication token for different
-type of connection or by passing a certificate chain to use for TLS.
+This in turn needs to provide the client credentials in the form of
`org.apache.pulsar.client.api.AuthenticationDataProvider`. This leaves the
chance to return different kinds of authentication token for different type of
connection or by passing a certificate chain to use for TLS.
Review comment:
maybe "a different type" or "different types"?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services