lhotari commented on code in PR #25822: URL: https://github.com/apache/pulsar/pull/25822#discussion_r3275362630
########## pulsar-common/src/main/java/org/apache/pulsar/common/scalable/SegmentInfo.java: ########## @@ -35,15 +35,23 @@ * Used for retention-based segment GC and for timestamp-based seek.</li> * </ul> * - * @param segmentId monotonically increasing, unique within the topic - * @param hashRange inclusive hash range [start, end] - * @param state ACTIVE or SEALED - * @param parentIds parent segment IDs in the DAG (empty for initial/root segments) - * @param childIds child segment IDs in the DAG (empty for active leaf segments) - * @param createdAtEpoch DAG epoch when this segment was created - * @param sealedAtEpoch DAG epoch when sealed (-1 if still active) - * @param createdAtMs wall-clock millis at creation time - * @param sealedAtMs wall-clock millis at seal time (-1 if still active) + * <p>A segment may be a <i>special segment</i> — one that wraps an existing Review Comment: could we call "special segment" something else? "special" can be vague and having a more meaningful concept would help in naming of other fields and methods. Perhaps "adaption segment", "adaptor segment", "adapted segment", "migration segment", "migrated segment", etc. to capture the meaning? For underlyingTopicName, perhaps it could be "adaptedV4TopicName" ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
