merlimat commented on code in PR #25822: URL: https://github.com/apache/pulsar/pull/25822#discussion_r3277190986
########## pulsar-common/src/main/java/org/apache/pulsar/common/scalable/SegmentInfo.java: ########## @@ -35,15 +35,23 @@ * Used for retention-based segment GC and for timestamp-based seek.</li> * </ul> * - * @param segmentId monotonically increasing, unique within the topic - * @param hashRange inclusive hash range [start, end] - * @param state ACTIVE or SEALED - * @param parentIds parent segment IDs in the DAG (empty for initial/root segments) - * @param childIds child segment IDs in the DAG (empty for active leaf segments) - * @param createdAtEpoch DAG epoch when this segment was created - * @param sealedAtEpoch DAG epoch when sealed (-1 if still active) - * @param createdAtMs wall-clock millis at creation time - * @param sealedAtMs wall-clock millis at seal time (-1 if still active) + * <p>A segment may be a <i>special segment</i> — one that wraps an existing Review Comment: Good call — renamed throughout. I went with **"legacy segment"** and `legacyTopicName`: a legacy segment is one that is *not* managed by the scalable-topic controller and has no `segment://...` URI of its own — it wraps an existing, externally managed `persistent://...` topic. The Javadoc spells out that externally-managed framing. Applied to the proto field (`underlying_topic_name` → `legacy_topic_name`), `SegmentInfo` (`activeSpecial` → `activeLegacy`, `isSpecial` → `isLegacy`), and the V5 SDK in the follow-up PR. Pushed in 74fab13. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
