jiazhai commented on a change in pull request #5151: Broker fails to start with
function worker enabled and broker client using TLS
URL: https://github.com/apache/pulsar/pull/5151#discussion_r323023781
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/PulsarBrokerStarter.java
##########
@@ -160,7 +160,9 @@ private static boolean argsContains(String[] args, String
arg) {
workerConfig =
WorkerConfig.load(starterArguments.fnWorkerConfigFile);
}
// worker talks to local broker
- boolean useTls = workerConfig.isUseTls();
+ // If the broker client is configured to use TLS, then we
+ // configure the function worker to use TLS
+ boolean useTls = brokerConfig.isBrokerClientTlsEnabled();
Review comment:
With this change `workerConfig.isUseTls()` will not take effect any more.
This seems not friendly for worker config.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
