jiazhai commented on a change in pull request #5151: Broker fails to start with
function worker enabled and broker client using TLS
URL: https://github.com/apache/pulsar/pull/5151#discussion_r323024509
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/PulsarBrokerStarter.java
##########
@@ -187,7 +189,7 @@ private static boolean argsContains(String[] args, String
arg) {
workerConfig.setZooKeeperSessionTimeoutMillis(brokerConfig.getZooKeeperSessionTimeoutMillis());
workerConfig.setZooKeeperOperationTimeoutSeconds(brokerConfig.getZooKeeperOperationTimeoutSeconds());
- workerConfig.setUseTls(brokerConfig.isTlsEnabled());
+ workerConfig.setUseTls(useTls);
Review comment:
this changes is right. we should reuse var `useTls`. As commenets above,
value for `useTls` need more confirm
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
