david-streamlio commented on code in PR #31: URL: https://github.com/apache/pulsar-connectors/pull/31#discussion_r3530084552
########## kafka-connect-adaptor/src/main/java/org/apache/pulsar/io/kafka/connect/AbstractKafkaConnectSource.java: ########## @@ -43,6 +43,8 @@ import org.apache.kafka.connect.source.SourceRecord; import org.apache.kafka.connect.source.SourceTask; import org.apache.kafka.connect.source.SourceTaskContext; +import org.apache.kafka.connect.json.JsonConverter; +import org.apache.kafka.connect.json.JsonConverterConfig; Review Comment: Nit: these two imports are inserted after `...connect.source.*`, but the rest of the block is alphabetized and `json` sorts before `source`/`storage`. CI didn't flag it, but it will bite if/when checkstyle parity with apache/pulsar is enforced here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
