david-streamlio commented on PR #31: URL: https://github.com/apache/pulsar-connectors/pull/31#issuecomment-4894876412
@kasparjarek Following up on my review — since maintainer edits were enabled, I pushed 91115f2 to your branch rather than just describing the test in a comment. It adds the `MemoryOffsetBackingStore`-based round-trip test from my review (plus the `createOffsetConverter` extraction it needs), and narrows the module's test disable to only the broker-dependent test files so the new test — and `PulsarSchemaToKafkaSchemaTest` — run in CI again. Verified locally with `./gradlew :kafka-connect-adaptor:test :kafka-connect-adaptor:check`. Feel free to amend or drop it if you'd rather take a different approach — and that resolves my blocking comment (#1) from the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
