Denovo1998 commented on code in PR #26179:
URL: https://github.com/apache/pulsar/pull/26179#discussion_r3565886528
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##########
@@ -460,14 +461,17 @@ protected CompletableFuture<Void>
internalCreateNonPartitionedTopicAsync(boolean
// We must not re-create
non-durable subscriptions on the new partitions
.stream().filter(entry ->
entry.getValue().isDurable())
.map(entry -> {
+ Map<String, String>
subscriptionProperties =
+
filterSubscriptionPropertiesForPartitionExpansion(
+
entry.getValue().getSubscriptionProperties());
Review Comment:
Filtering here addresses partition expansion, but since #26159, the Admin
`getSubscriptionProperties` endpoint returns raw cursor properties, including
`#pulsar.internal.*`, while `updateSubscriptionProperties` delegates to
`ManagedCursorImpl#setCursorProperties`, which rejects maps containing that
prefix. Consequently, a GET → modify → PUT cycle can fail once bucket state
exists. Should we note a follow-up to restore the user/internal property
boundary for instance, by exposing filtered user properties through the Admin
API while keeping raw cursor properties accessible only to broker internals?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
