void-ptr974 commented on code in PR #26179:
URL: https://github.com/apache/pulsar/pull/26179#discussion_r3566289117
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##########
@@ -460,14 +461,17 @@ protected CompletableFuture<Void>
internalCreateNonPartitionedTopicAsync(boolean
// We must not re-create
non-durable subscriptions on the new partitions
.stream().filter(entry ->
entry.getValue().isDurable())
.map(entry -> {
+ Map<String, String>
subscriptionProperties =
+
filterSubscriptionPropertiesForPartitionExpansion(
+
entry.getValue().getSubscriptionProperties());
Review Comment:
Thanks for pointing this out. I agree this is a separate issue around the
public API boundary. Since it is outside the partition-expansion fix in this
PR, I would prefer to track it in a follow-up issue/PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
