void-ptr974 commented on PR #26180: URL: https://github.com/apache/pulsar/pull/26180#issuecomment-4951515992
Could you clarify the concrete external use case that requires `PendingAcksMap#get`? `PendingAcksMap` and this method expose broker dispatcher implementation state; they are not a supported user-facing API or a broker-extension compatibility contract. After #26030, broker code uses the primitive accessors and no longer needs this pair-returning API. Restoring it only to preserve a hypothetical call site would add an internal representation, including the `fastutil` `IntIntPair` type, to the compatibility surface and turn obsolete implementation detail into long-term maintenance debt. Unless there is a concrete supported use case, I do not think we should restore this method. If an extension genuinely needs this information, we should define a dedicated supported API rather than expose `PendingAcksMap` directly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
