Denovo1998 commented on PR #26180: URL: https://github.com/apache/pulsar/pull/26180#issuecomment-4957584488
@lhotari Oh, I was just reviewing the PRs that have been merged every week and found potential issues. Although MoP uses getPendingAcks().remove(...), which indicates that someone is indeed accessing this internal state, it may not prove that the removed get has an actual use case. https://github.com/streamnative/mop/blob/edd40621925c08eab0c910fb1f84fc9b6501fae7/mqtt-broker/src/main/java/io/streamnative/pulsar/handlers/mqtt/broker/processor/MQTTBrokerProtocolMethodProcessor.java#L167-L192 So I think it's okay to close this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
