merlimat commented on a change in pull request #82: Added a message id tracker for acking messages that are batched. URL: https://github.com/apache/pulsar-client-go/pull/82#discussion_r341834812
########## File path: pulsar/impl_message.go ########## @@ -126,3 +142,36 @@ func (msg *message) EventTime() time.Time { func (msg *message) Key() string { return msg.key } + +func newAckTracker(size int) *ackTracker { Review comment: Since this ack tracker is self-contained, should we move it into a separate file, perhaps in the `internal` pkg? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services