merlimat commented on a change in pull request #82: Added a message id tracker 
for acking messages that are batched.
URL: https://github.com/apache/pulsar-client-go/pull/82#discussion_r344455571
 
 

 ##########
 File path: pulsar/impl_message.go
 ##########
 @@ -18,30 +18,31 @@
 package pulsar
 
 import (
+       "math/big"
+       "strings"
+       "sync"
        "time"
 
-       "github.com/apache/pulsar-client-go/pkg/pb"
        "github.com/golang/protobuf/proto"
-)
 
-func earliestMessageID() MessageID {
-       return newMessageID(-1, -1, -1, -1)
-}
+       "github.com/apache/pulsar-client-go/pkg/pb"
+)
 
 type messageID struct {
        ledgerID     int64
        entryID      int64
        batchIdx     int
        partitionIdx int
+
+       tracker *ackTracker
 
 Review comment:
   @sijie can you take another look? the other approach would involve a lot of 
downcasting, which we're actively trying to avoid. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to