jerrypeng commented on a change in pull request #5400: [functions] Allow
functions to pass runtime specific options
URL: https://github.com/apache/pulsar/pull/5400#discussion_r344413435
##########
File path:
pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/kubernetes/KubernetesRuntimeFactory.java
##########
@@ -267,7 +281,8 @@ public void close() {
public void doAdmissionChecks(Function.FunctionDetails functionDetails) {
KubernetesRuntime.doChecks(functionDetails);
validateMinResourcesRequired(functionDetails);
- secretsProviderConfigurator.doAdmissionChecks(appsClient, coreClient,
jobNamespace, functionDetails);
+ KubernetesManifestCustomizer manifestCustomizer =
buildManifestCustomizer(functionDetails);
Review comment:
Why do we need to add this here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
