jerrypeng commented on a change in pull request #5400: [functions] Allow
functions to pass runtime specific options
URL: https://github.com/apache/pulsar/pull/5400#discussion_r345049439
##########
File path:
pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/auth/KubernetesFunctionAuthProvider.java
##########
@@ -30,7 +32,7 @@
*/
public interface KubernetesFunctionAuthProvider extends FunctionAuthProvider {
- void initialize(CoreV1Api coreClient, String kubeNamespace, byte[]
caBytes);
+ void initialize(CoreV1Api coreClient, byte[] caBytes,
java.util.function.Function<Function.FunctionDetails, String>
namespaceCustomizerFunc);
Review comment:
Since caBytes and namespaceCustomizerFunc are essentially optional
arguments, let's add setters for them to be with default being a no-op so that
the interface can be cleaner. Not all implementations will require caBytes and
namespaceCustomizerFunc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
