merlimat commented on a change in pull request #86: Simplify and refactor parts
of the single topic consumer.
URL: https://github.com/apache/pulsar-client-go/pull/86#discussion_r344855765
##########
File path: pulsar/consumer.go
##########
@@ -139,46 +141,15 @@ type Consumer interface {
// This calls blocks until a message is available.
Receive(context.Context) (Message, error)
- // ReceiveAsync appends the message to the msgs channel asynchronously.
- ReceiveAsync(ctx context.Context, msgs chan<- ConsumerMessage) error
-
- // ReceiveAsyncWithCallback returns a callback containing the message
and error objects
- ReceiveAsyncWithCallback(ctx context.Context, callback func(msg
Message, err error))
+ // Messages returns a channel to consumer messages from
+ Messages() <-chan ConsumerMessage
Review comment:
Wouldn't be more intuitive to call this `Chan()` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
