merlimat commented on a change in pull request #86: Simplify and refactor parts
of the single topic consumer.
URL: https://github.com/apache/pulsar-client-go/pull/86#discussion_r344859674
##########
File path: pulsar/internal/connection.go
##########
@@ -286,7 +285,10 @@ func (c *connection) run() {
if req == nil {
return
}
- c.pendingReqs[req.id] = req
+ // does this request expect a response?
+ if req.id != RequestIDNoResponse {
Review comment:
Rather than having a special value (for users), I'd prefer for the
`..NoWait()` variant to not take a request id since it will never be used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
