cckellogg commented on a change in pull request #86: Simplify and refactor
parts of the single topic consumer.
URL: https://github.com/apache/pulsar-client-go/pull/86#discussion_r344882908
##########
File path: pulsar/consumer.go
##########
@@ -91,7 +93,7 @@ type ConsumerOptions struct {
// InitialPosition at which the cursor will be set when subscribe
// Default is `Latest`
- SubscriptionInitPos InitialPosition
+ SubscriptionInitPos SubscriptionInitialPosition
Review comment:
I was trying to be more descriptive for example:
```
pulsar.InitialPosition
vs
pulsar.SubscriptionInitialPosition
```
The second one seemed clearer to me. Thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
