cckellogg commented on a change in pull request #86: Simplify and refactor
parts of the single topic consumer.
URL: https://github.com/apache/pulsar-client-go/pull/86#discussion_r344884259
##########
File path: pulsar/internal/connection.go
##########
@@ -286,7 +285,10 @@ func (c *connection) run() {
if req == nil {
return
}
- c.pendingReqs[req.id] = req
+ // does this request expect a response?
+ if req.id != RequestIDNoResponse {
Review comment:
That makes sense. Should we make that change in the current pr or do a new
one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
