zhaohaidao commented on a change in pull request #5767: Support batch
authorization of partitioned topic
URL: https://github.com/apache/pulsar/pull/5767#discussion_r352337822
##########
File path:
pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/PersistentTopicsTest.java
##########
@@ -312,4 +316,82 @@ public void testGetPartitionedTopicsList() throws
KeeperException, InterruptedEx
Assert.assertEquals(nonPersistentPartitionedTopics.size(), 1);
Assert.assertEquals(TopicName.get(nonPersistentPartitionedTopics.get(0)).getDomain().value(),
TopicDomain.non_persistent.value());
}
+
+ @Test
+ public void testGrantNonPartitionedTopic() {
+ final String topicName = "non-partitioned-topic";
+ persistentTopics.createNonPartitionedTopic(testTenant, testNamespace,
topicName, true);
+ String role = "role";
+ Set<AuthAction> expectActions = new HashSet<>();
+ expectActions.add(AuthAction.produce);
+ persistentTopics.grantPermissionsOnTopic(testTenant, testNamespace,
topicName, role, expectActions);
+ Map<String, Set<AuthAction>> permissions =
persistentTopics.getPermissionsOnTopic(testTenant, testNamespace, topicName);
+ Assert.assertEquals(permissions.get(role), expectActions);
+ }
+
+ @Test
+ public void testGrantPartitionedTopic() {
+ final String partitionedTopicName = "partitioned-topic";
+ final int numPartitions = 5;
+ LocalZooKeeperCacheService mockLocalZooKeeperCacheService =
mock(LocalZooKeeperCacheService.class);
+ ZooKeeperChildrenCache mockZooKeeperChildrenCache =
mock(ZooKeeperChildrenCache.class);
+
doReturn(mockLocalZooKeeperCacheService).when(pulsar).getLocalZkCacheService();
+
doReturn(mockZooKeeperChildrenCache).when(mockLocalZooKeeperCacheService).managedLedgerListCache();
Review comment:
> you can provide this support in the internalGetPermissionsOnTopic function.
Is it better to create a new api called getPermissionsOnPartitionedTopic?
I understand if I support searching partitioned topic in
internalGetPermissionsOnTopic. The output structure of getPermissionsOnTopic
will be changed to
Map<String, Map<String, Set<AuthAction>> which will break API compatibility?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
