cckellogg commented on a change in pull request #157: [issue:144] Add retry
logic when get connection error
URL: https://github.com/apache/pulsar-client-go/pull/157#discussion_r362556154
##########
File path: pulsar/internal/rpc_client.go
##########
@@ -105,6 +110,27 @@ func (c *rpcClient) Request(logicalAddr *url.URL,
physicalAddr *url.URL, request
}
}
+func (c *rpcClient) getConn(logicalAddr *url.URL, physicalAddr *url.URL,
+ connectingThroughProxy bool) (Connection, error) {
+ cnx, err := c.pool.GetConnection(logicalAddr, physicalAddr,
connectingThroughProxy)
+ backoff := new(Backoff)
+ var retryTime time.Duration
+ if err != nil {
+ for retryTime < c.requestTimeout {
Review comment:
How long will this retry for?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
