merlimat commented on a change in pull request #157: [issue:144] Add retry
logic when get connection error
URL: https://github.com/apache/pulsar-client-go/pull/157#discussion_r363099770
##########
File path: pulsar/internal/connection_pool.go
##########
@@ -65,7 +65,7 @@ func (p *connectionPool) GetConnection(logicalAddr *url.URL,
physicalAddr *url.U
return cnx, nil
}
// The cached connection is failed
- p.pool.Delete(logicalAddr.Host)
+ p.pool.Delete(fmt.Sprintf("%s:%v", logicalAddr.Host,
connectingThroughProxy))
Review comment:
@wolfstudy The retry logic in the RPC client is good. We should add it to
avoid pushing spurious errors back to the application (eg: when only 1 broker
is getting restarted).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
