devinbost opened a new pull request #6031: [Issue 4175] [pulsar-function-go] 
(ongoing) Fixed gRPC file to contain service registration method
URL: https://github.com/apache/pulsar/pull/6031
 
 
   Partial fix required for #4175. 
   Addresses issue documented here: https://github.com/grpc/grpc-go/issues/3310
   Part of ongoing work to add the gRPC service for heartbeat functionality and 
related support for running Go functions. 
   
   ### Motivation
   Progress was blocked by the issue documented above. 
   
   ### Modifications
   
   1. Updated ./generate.sh script in pulsar-function-go module to use the grpc 
plugin. 
   2. Rebuilt Go gRPC files using the grpc plugin. This updated the proto 
version and was mostly an additive change that included adding the new 
registration methods required for creating the Go gRPC service. 
   
   ### Verifying this change
   
   - Unable to test change due to build errors in code that was already in 
master. (Existing Go tests failed.) Currently investigating. 
   - More testing will be done in subsequent commits because the Go gRPC 
functionality is not yet complete. (Should be low impact.)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to