wolfstudy commented on issue #6031: [Issue 4175] [pulsar-function-go] (ongoing) Fixed gRPC file to contain service registration method URL: https://github.com/apache/pulsar/pull/6031#issuecomment-573981126 > It turns out that the issue in the `context_test.go` test was in `FunctionContext.GetInputTopics()`. > The instance method gets its valued populated by `goInstance.setupConsumer()`, which must not have been getting run in the test. I changed the getter on the functionContext to get the inputTopic values directly from `functionContext.instanceConf.funcDetails.GetSource().InputSpecs`. > We may want to remove dependencies on the functionContext.inputTopics field (and remove the field altogether) to prevent confusion later on. > Also, the conf.yaml values must have been changed, so I updated the test to match the values that were being provided. > It's passing locally for me. > > I also added a new test file `instanceControlServicer_test.go` that tests that a gRPC server can be created and successfully connected to. > > We probably still need to test the entire thing end-to-end to ensure that concurrency issues weren't introduced anywhere and that I'm starting the servicer in the correct location. Thanks @devinbost agree with you, maybe we can remove `inputTopics` filed of `FunctionContext` . Can you help to fix the `context_test.go` file?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
