sijie commented on a change in pull request #6052: [PIP-54] Acknowledgement for
batch message local index
URL: https://github.com/apache/pulsar/pull/6052#discussion_r367965258
##########
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java
##########
@@ -148,6 +152,10 @@
return position;
};
private final LongPairRangeSet<PositionImpl> individualDeletedMessages;
+
+ // Maintain the indexes deleted status of batch messages that not deleted
completely
+ // (ledgerId, entryId, batchSize) -> deleted indexes
+ private final ConcurrentHashMap<PositionImpl, ConcurrentBitSet>
batchDeletedIndexes;
Review comment:
I think we can initialize this lazily since people might not enable this
feature at all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
